-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding way to configure a layer paint in flame tiled #2851
Conversation
64911ba
to
469af99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does things a bit differently than what we do everywhere else where we pass along a Paint
object. Meanwhile this looks quite handy, shouldn't we first and foremost go for consistency?
I also don't understand fully, why is only the opacity
an input to the factory function?
Yeah, so, from what I understood from Flame Tiled code (I am still getting used to all of its structure haha). There is one paint per layer. That paint should contain the opacity of such layer, hence why the factory receives the opacity, so the paint can be built taking that into consideration. I am not sure how we could do if Usually I would be more for the consistency, but in this case I don't see how we could accommodate by passing the objects. |
It should be possible to pass down a factory function through the |
Ah, alright, I thought you mentioned passing down the instantiated objects, not the factory itself. That we can do!!!! |
Description
Creates a configuration in Flame Tiled that allows developers to use custom paint objects which can be useful when we need to render tilesets that require a different Paint configuration other than the default one. Like low rez pixel art tilesets which benefits from using filterQuality.none
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
Replace or remove this text.